quattor/functions/network copy_network_params: bootproto=none for unconfigured interfaces #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouvin
force-pushed
the
interface_bootproto_default_none
branch
from
6291253 to
0673d29
Compare
|
The |
|
I'd prefer if it were called something less ambiguous like |
|
I don't think I've shared it before, but we use this simple script for situations where we need to rename something globally: https://gist.github.com/jrha/f8373418cac4ed2ad6f5e5be08d096c3 |
|
Ok, I'll do it. |
|
Thanks! |
jrha
changed the title
|
Can you remove the |
|
Sure! |
…nconfigured interfaces
jouvin
force-pushed
the
interface_bootproto_default_none
branch
from
0673d29 to
17d7af3
Compare
|
Should be ok now... |
jrha
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nmstateto work properly for unconfigured interfacesI mark this PR as backward incompatible as it changes the resulting profile compared to previous version but I think it fixes something that was wrong but working with initscripts (because they don't care about interfaces not enabled on boot).